It appears to pass all tests, but I’m not sure if my test writing skills are necessarily that great, I semi-followed the learn go with tests eBook. I appreciate any feedback, and if this isn’t an appropriate post for this community just let me know and I’ll remove.

Thanks!!

  • spacedogroy@feddit.uk
    link
    fedilink
    English
    arrow-up
    0
    ·
    7 days ago

    I haven’t gone through it thoroughly but the first thing that stuck out was the use of a default logger. I don’t think libraries should log by default. If you do allow a logger to be injected in I think it should be an interface.

    • tapdattl@lemmy.worldOP
      link
      fedilink
      arrow-up
      0
      ·
      6 days ago

      I don’t think libraries should log by default

      That’s a fair point, interfaces are still a concept that boggle my mind a bit, but maybe this is the problem that will help me actually grasp them. Thanks!